Forestry update #5737
Forestry update #5737
Conversation
|
Apart from the few comments, it looks good as long as its tested and feedback has been addressed |
| @@ -236,7 +236,7 @@ export const woodcuttingTask: MinionTask = { | |||
|
|
|||
| let strungRabbitFoot = user.hasEquipped('Strung rabbit foot'); | |||
| let twitchersEquipped = user.hasEquipped("twitcher's gloves"); | |||
| let twitcherSetting = ''; | |||
| let twitcherSetting: TwitcherGloves | undefined = undefined; | |||
There was a problem hiding this comment.
I dont know if it should be or not, but you dont have the default here.
There was a problem hiding this comment.
I still had it as string in options. I fixed it. thanks for the catch
There was a problem hiding this comment.
oh i see what you're saying now, i just removed the default entirely so that no setting is selected. Do you think I should set this to a default? like let twitcherSetting: TwitcherGloves | undefined = 'egg';
Edit: went ahead and added back in the default egg for the gloves without the use of the commandoption
I did a round of testing with some testers a few days ago and all the feedback & bugs found were fixed. |
| @@ -93,6 +93,7 @@ async function handleForestry({ user, duration, loot }: { user: MUser; duration: | |||
| const event = ForestryEvents[eventIndex]; | |||
| const defaultEventXP = 5 * (randInt(85, 115) / 100); // used for unverified xp rates | |||
| let eggsDelivered = 0; | |||
| let beeHive = 0; | |||
There was a problem hiding this comment.
This variable should be given a better name, just reading it, i have 0 idea what it is for or does.
There was a problem hiding this comment.
I renamed it beeHiveRepairs to more accuratley reflect what it is. It's purpose is to get a more accurate xp rate to ingame xp rates.
for (let i = 0; i < randInt(5, 7); i++)
- accounts for the average of 6 beehives per event, 5-7 for variance depending on how "busy" the event is
beeHiveRepairs += randInt(5, 10);
- accounts for the users interaction with repairing the beehive, 5-10 for variance depending on how "busy" the event is
eventXP[event.uniqueXP] += user.skillLevel(event.uniqueXP) * 0.3 * beeHiveRepairs;
- beeHiveRepairs is then used here to give an accurate amount of construction xp per event based on the users con level
Description:
Forestry part two & forestry updates.
Changes:
/chopflags/dataTODO: Plan to add all these in their own PR since this PR is already fairly big
Other checks: